search

spacedockapp / spacedock

Star trek
Apache License 2.0
11 stars 10 forks source link

Implement Officers for Android #97

Closed tblackwe closed 9 years ago

tblackwe commented 10 years ago

Officers have been spoiled. Things to think about 1 resource, 1-4 upgrade slots (Resource costs 3,6,9, or 12 based on number of officers taken. Cost should be linked to the slot on the ship then, much like flagships or fleet captains) Officer cards are associated with crew, need 1 crew member for ever 1-2 officer cards They add Crew, Weapon, Tech, and Talent slots. First officer adds a captain skill

tblackwe commented 10 years ago

I've begun working on the code for Android Rob: when you are ready to start working on it let me know. I assume you will be adding Officer and OfficerBase to the core data. If not let me know.

rtsuk commented 10 years ago

I’ll add it to the data model tonight and generate the java classes.

It will be a resource plus another Upgrade subclass. I'll add two officer slots per crew member to the extra's section on iOS.

tblackwe commented 10 years ago

Awesome. thank you.

rtsuk commented 10 years ago

They are up. EquippedShipBase also changed due to the addition of a fleet captain attribute to that class in Core Data was overwritten. You might have some integrating to do.

rtsuk commented 10 years ago

So you edited one of the generated files, EquippedShipBase, for the Fleet Captain implementation. Is there any reason you couldn't move the changes to the derived file EquippedShip? Otherwise doing the code generation is going to get problematic.

tblackwe commented 10 years ago

I thought I had. Sorry. I see no reason I can't move it, but it won't be until tomorrow or Wednesday. On Aug 25, 2014 10:39 AM, "Rob Tsuk" notifications@github.com wrote:

So you edited one of the generated files, EquippedShipBase. for the Fleet Captain implementation. Is there any reason you couldn't move the changes to the derive file EquippedShip? Otherwise doing the code generation is going to get problematic.

— Reply to this email directly or view it on GitHub https://github.com/rtsuk/spacedock/issues/97#issuecomment-53272209.

rtsuk commented 10 years ago

No hurry, I don't think I'll be doing any more code generation soon. Data Model Two has a ways to go yet, although Factions are working.

rtsuk commented 10 years ago

Here's the iOS implementation. There are no placeholders for Officers, instead the UI adds the blank slots as needed.

When there are no officers, one empty officer slot appears in extras.

screen shot 2014-09-18 at 8 01 44 am

After one, there is an officer section. As long as there is room for another officers, there's a blank slot. The missing cost on the officer is a bug, it should have a 3 there.

screen shot 2014-09-18 at 8 13 41 am

Once the ship has all the officers it can hold the blank slot is omitted.

screen shot 2014-09-18 at 8 14 04 am

rrgeorge commented 9 years ago

Fixed.