Toggling the Inspector in Media View doesn't consistently resize the thumbnail grid.

0xBA5E64 commented 7 months ago

Describe the bug

When toggling the Inspector sidebar in Spacedrive, the media view thumbnail grid won't always consistently resize to make space on the side, instead displaying underneath the Inspector itself. Similarly, as the Inspector is closed, the thumbnail grid won't consistently re-claim said space:

https://github.com/spacedriveapp/spacedrive/assets/26796481/8a04e6f1-ac7c-444d-bc8b-5eeafec4cb95

This is consistent across all platforms I've tried (see Platform and versions below).

This seems to fix itself as the user scrolls down in the grid (likely causing some sort of update), but as you're likely not doing this while toggling the Inspector, this is quite apparent.

Reproduction

Open an indexed Location
Switch to Media View in the top bar or via Ctrl+3
Toggle the Inspector from the top right or by pressing Ctrl+I, repeatedly.
Observe as the Media View thumbnails randomly "clip" underneath the Inspector, or occasionally refuses to re-fill the space used by the Inspector

Expected behavior

The Media View thumbnails should only be compacted as the Inspector is displayed, and go back to using the full screen width once disabled.

Platform and versions

This has been tested on:
 - macOS Sonoma (v0.2.13)
 - Docker-container Web UI (`staging` tag: v0.2.12 - 2b5e03e)
 - Arch Linux (Unofficial "spacedrive" AUR-build @ v0.2.11 - eb16568) [current]
  - `pnpm 9.0.5 / cargo 1.77.1 (e52e36006 2024-03-26) / rustc 1.77.1 (7cf61ebde 2024-03-27)`

Stack trace

N/A

Additional context

The recording may seem laggy due to the sub-par performance I'm currently experiencing with the Linux build of the app. This may in part be due to the unofficial AUR build, but having tried the officially appimage build previously it was not much better unfortunately. (Performance in the browser is great however, yet experiences the same buggyness)

HeavenVolkoff commented 5 months ago

When toggling the Inspector sidebar in Spacedrive, the media view thumbnail grid won't always consistently resize to make space on the side, instead displaying underneath the Inspector itself. Similarly, as the Inspector is closed, the thumbnail grid won't consistently re-claim said space:

Oh, this is certainly not working as it should. I'll raise this internally, and we will fix it as soon as possible

The recording may seem laggy due to the sub-par performance I'm currently experiencing with the Linux build of the app. This may in part be due to the unofficial AUR build, but having tried the officially appimage build previously it was not much better unfortunately. (Performance in the browser is great however, yet experiences the same buggyness)

Yeah, this is a known issue, unfortunately Linux releases are currently locked to gtk3, which uses an old webkit2gtk version that has some performance issues with complex web apps. This is due to Tauri not supporting gtk4, we are currently looking for an alternative solution specifically Linux

0xBA5E64 commented 5 months ago

I can confirm this issue still persists on version 0.3.1, running on macOS

spacedriveapp / spacedrive