Closed oscartbeaumont closed 4 weeks ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
relay_test | ❌ Failed (Inspect) | May 30, 2024 6:35am |
@myung03 Thank you very much for this thorough review you brought up a lot of good points.
Any TODO
across the docs is a marker for me to come back to it before I finish at SD on Friday. I opened this PR up for review because it contains some breaking changes to the Cloud pairing process and I was trying not to block Brendan although I noticed a couple of mistakes in the code so changed it back to a draft.
The first-person language is definitely not great for docs but I've also tried to include information about the rational or alternative perspectives which are ultimately subjective and I wanted to convey it's a personal opinion not an opinion of Spacedrive. Although, I think you're completely right it is not necessary in many places.
This PR contains:
A small amount of TODO's remain in the docs but I will follow up with another PR. This PR contains some breaking changes to the cloud pairing so it's better off getting merged.