spacedriveapp / spacedrive

Spacedrive is an open source cross-platform file explorer, powered by a virtual distributed filesystem written in Rust.
https://spacedrive.com
GNU Affero General Public License v3.0
29.34k stars 835 forks source link

More P2P docs #2492

Closed oscartbeaumont closed 4 weeks ago

oscartbeaumont commented 1 month ago

This PR contains:

A small amount of TODO's remain in the docs but I will follow up with another PR. This PR contains some breaking changes to the cloud pairing so it's better off getting merged.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
relay_test ❌ Failed (Inspect) May 30, 2024 6:35am
2 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **spacedrive-landing** | ⬜️ Ignored ([Inspect](https://vercel.com/spacedrive/spacedrive-landing/BrfZ2PfxUBLPu4wEZcZxD5f77bA9)) | [Visit Preview](https://spacedrive-landing-git-p2p-relay-improvements-spacedrive.vercel.app) | | May 30, 2024 6:35am | | **spacedrive-web** | ⬜️ Ignored ([Inspect](https://vercel.com/spacedrive/spacedrive-web/7gJ7mVytfdRYBKi7FEjqCMnRh8Eb)) | [Visit Preview](https://spacedrive-web-git-p2p-relay-improvements-spacedrive.vercel.app) | | May 30, 2024 6:35am |
oscartbeaumont commented 1 month ago

@myung03 Thank you very much for this thorough review you brought up a lot of good points.

Any TODO across the docs is a marker for me to come back to it before I finish at SD on Friday. I opened this PR up for review because it contains some breaking changes to the Cloud pairing process and I was trying not to block Brendan although I noticed a couple of mistakes in the code so changed it back to a draft.

The first-person language is definitely not great for docs but I've also tried to include information about the rational or alternative perspectives which are ultimately subjective and I wanted to convey it's a personal opinion not an opinion of Spacedrive. Although, I think you're completely right it is not necessary in many places.