spacedriveapp / spacedrive

Spacedrive is an open source cross-platform file explorer, powered by a virtual distributed filesystem written in Rust.
https://spacedrive.com
GNU Affero General Public License v3.0
29.33k stars 835 forks source link

"New Update Available" toast not disappearing after update #2519

Closed zaaakher closed 3 weeks ago

zaaakher commented 4 weeks ago

Describe the bug

I got a toast in the bottom right corner telling me there's a new update. After clicking on "update" and going to through the wizard and SpaceDrive opens up again the toast shows up again telling me to update again even though SpaceDrive is already the latest version.

I actually fell for it and updated SpaceDrive twice πŸ˜…

image

Reproduction

  1. Make sure your SpaceDrive app is not up to date.
  2. You'll see a "New Update Available" toast on the bottom right corner
  3. Click on the "update" action button in that toast and go through the installation wizard
  4. SpaceDrive will open up again after the update ( or you can open SpaceDrive manually)
  5. You'll see the toast again even though your SpaceDrive is up to date.

Expected behavior

The "New Update Available" toast should not appear again after updating SpaceDrive.

I think there should be a check to see if the SpaceDrive version the user has is up to date or not. If so, then don't show the toast, otherwise keep showing it every time they open the SpaceDrive app.

Platform and versions

Windows 10 Pro (Build 19045.4291)
pnpm: v9.1.3
cargo: n/a
rustc: n/a

Stack trace

No response

Additional context

No response

zaaakher commented 4 weeks ago

I noticed the same thing with the "Install Update" button on the side menu. πŸ‘‡ It seems to be that the function that detects if the app needs to be updated is not really detecting the current version of my app and matching it with the actual latest release of the SpaceDrive

image

zaaakher commented 4 weeks ago

Tracing the issue back to where it could potentially be from:

Either from the desktop updater in desktop/src/updater.tsx

Or from the tauri updater in desktop/src-tauri/src/updater.rs

HeavenVolkoff commented 3 weeks ago

I think this was solved by #2517, I am building a test release rn to make sure, will post the link here when it is available so any people experiencing this can test.

HeavenVolkoff commented 3 weeks ago

The test release is available here: https://github.com/spacedriveapp/spacedrive/actions/runs/9292624870

zaaakher commented 3 weeks ago

@HeavenVolkoff ok I downloaded the Spacedrive-windows-x86_64.msi file and installed it. Seems to be working fine with no toast or any msg telling me to update πŸ‘

Although on a side note that could be irrelevant: During the installation of that test release I got this warning

image

davidjaggi commented 3 weeks ago

I experience the same issue. This was also an issue in an earlier release but the solved via an update.

ketonik commented 3 weeks ago

Nice work guys, resolved for me too Spacedrive-windows-x86_64.msi at https://github.com/spacedriveapp/spacedrive/actions/runs/9292624870/artifacts/1550110422

Edition Windows 11 Pro for Workstations Version 23H2 Installed on β€Ž30/β€Ž09/β€Ž2023 OS build 22635.3646 Experience Windows Feature Experience Pack 1000.22700.1013.0

utkubakir commented 3 weeks ago

Perfect, we will be pushing an update soon

zaaakher commented 3 weeks ago

Just tested it again with the official release v0.3.1 and this issue is resolved πŸ‘ Thanks @HeavenVolkoff @utkubakir