[ENG-1793] Introduce error handling for sd-core-sync crate

spacedriveapp / spacedrive

Spacedrive is an open source cross-platform file explorer, powered by a virtual distributed filesystem written in Rust.

https://spacedrive.com

GNU Affero General Public License v3.0

31.53k stars 931 forks source link

[ENG-1793] Introduce error handling for sd-core-sync crate #2556

Closed fogodev closed 2 months ago

fogodev commented 3 months ago

Introducing error handling for the sd-core-sync crate, also a bunch of tweaking here and there, using stronger clippy lints.

linear[bot] commented 3 months ago

ENG-1793 Introduce error handling for sd-core-sync crate

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
spacedrive-landing	❌ Failed (Inspect)			Jul 16, 2024 10:01pm

1 Skipped Deployment

ameer2468 commented 2 months ago

@fogodev @HeavenVolkoff Any updates on this? lets get it merged if there's no issues.

fogodev commented 2 months ago

@fogodev @HeavenVolkoff Any updates on this? lets get it merged if there's no issues.

I would like @Rocky43007 to review if possible, as he has the most sync experience.

Rocky43007 commented 2 months ago

I'll have it reviewed by Monday.

Rocky43007 commented 2 months ago

I am getting the following error when trying cloud sync, was this supposed to happen?

Happens when the cloud sync ingester and sender die. Turning them off and on again works, usually. That, or the backend just doesn't want to send data sometimes.

fogodev commented 2 months ago

Will check them out