search

spacefill / gibbon-mail

Send mails with mjml Template and JSON Schema
3 stars 1 forks source link

feat(backend,mail-templates): Add Nunjucks include support #38 #40

Closed abordin-spacefill closed 1 year ago

abordin-spacefill commented 1 year ago

Add Nunjucks include support, with an example about how to use it, in .mjml and .txt templates.

Its-Alex commented 1 year ago

@abordin-spacefill Please feel free to open a PR directly from Spacefill repository next time :pray:

Its-Alex commented 1 year ago

@abordin-spacefill Can you add some tests in https://github.com/spacefill/gibbon-mail/tree/master/backend/test to check that nunjuck import work?

Its-Alex commented 1 year ago

@abordin-spacefill Please can you bump version to 0.5.0 following https://github.com/spacefill/gibbon-mail#how-to-publish-a-tag in another commit? (Be wary to just bump version and not create a tag)

Its-Alex commented 1 year ago

@abordin-spacefill I have one problem on this MR it's that the template are not auto reloading on refresh, for example if I change a template and reload frontends I have no modifications. Before your PR that was working 😅

abordin-spacefill commented 1 year ago

@Its-Alex PR updated, all points should be ok now.

Its-Alex commented 1 year ago

Closed in favor of https://github.com/spacefill/gibbon-mail/pull/41