netlify[bot]
commented
11 months ago Deploy Preview for spacelab-main ready!
| Name | Link |
|---|---|
| Latest commit | dc1a60e71f735febcfbd1780b042640f1c475792 |
| Latest deploy log | https://app.netlify.com/sites/spacelab-main/deploys/6570d1f60c982b0008038c14 |
| Deploy Preview | https://deploy-preview-445--spacelab-main.netlify.app/ |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
What I did:
Two form input types were incorrectly set to "firstName" and "lastName". I changed these type attributes back to "text". reference of valid input types: https://www.w3schools.com/html/html_form_input_types.asp
Added aria-labels to firstName, lastName, and email inputs. I don't think Anna suggested this method but it is a valid (and simpler!) approach. reference: https://www.w3.org/WAI/tutorials/forms/labels/#:~:text=The%20aria%2Dlabel%20attribute%20can,not%20conveyed%20to%20visual%20users.
I did not add an aria-label for the button because the "Subscribe" text is nested between the button tags, which screen readers will announce. reference: https://webaim.org/techniques/forms/controls#button