spacelift-io / terraform-provider-spacelift

Terraform provider to interact with Spacelift
MIT License
76 stars 29 forks source link

Update stack_gcp_service_account.md #261

Closed jzck closed 2 years ago

jzck commented 2 years ago

Description of the change

This part of the documentation was out of date. (see error message below).

Type of change

Development

│ [
│   {
│     "@type": "type.googleapis.com/google.rpc.BadRequest",
│     "fieldViolations": [
│       {
│         "description": "Policy members must be prefixed of the form 'type:value', where type is 'domain', 'group', 'serviceAccount', or 'user'.",
│         "field": "policy.bindings.member"
│       }
│     ]
│   },
│   {
│     "@type": "type.googleapis.com/google.rpc.ErrorInfo",
│     "domain": "cloudresourcemanager.googleapis.com",
│     "reason": "PROJECT_SET_IAM_DISALLOWED_MEMBER_TYPE"
│   },
│   {
│     "@type": "type.googleapis.com/google.rpc.ResourceInfo",
│     "resourceName": "projects/alg-foundation"
│   }
│ ]

Code review

marcinwyszynski commented 2 years ago

Hey! Thanks for bringing it to our attention!

The docs are autogenerated using this tool so the required change is subtly different, but no need to resubmit the PR, we'll take it from here.

jzck commented 2 years ago

we'll take it from here.

Ok thanks, feel free to close this PR whenever.

marcinwyszynski commented 2 years ago

This has been released in 0.1.11.