Add support for user group resources

mwasilew2 commented 1 year ago

Description of the change

User need

User Management is a feature that is in closed beta right now. Most of it is already implemented, but there are still some bits and pieces missing. One example of a missing bit is that the terraform provider is missing support for managing resources related to User Management. This PR is intended to improve on that by adding support for managing user group resources.

Solution

Add support to the spacelift terraform provider for managing User Management related objects.

Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation (non-breaking change that adds documentation)

Related issues

Checklists

Development

[x] Lint rules pass locally
[x] The code changed/added as part of this pull request has been covered with tests
[x] All tests related to the changed code pass in development
[x] Examples for new resources and data sources have been added
[x] Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
[x] If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

[x] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[x] Pull Request is no longer marked as "draft"
[ ] Reviewers have been assigned
[ ] Changes have been reviewed by at least one other engineer

mwasilew2 commented 1 year ago

The tests pass against my local instance. My current suspicion is that they fail in Github Actions because the API which the tests run against doesn't include the relevant graphql schema changes.

The provider uses SPACELIFT_API_KEY_ENDPOINT . I wanted to look it up in the repo config, but all env vars are stored as secrets so there's no way to check it that way.

mwasilew2 commented 1 year ago

@adamconnelly @truszkowski @marcinwyszynski

I'm troubleshooting: https://github.com/spacelift-io/terraform-provider-spacelift/actions/runs/6407726212/job/17395133360?pr=473

I noticed you've been recently active in this repo, do you know which instance is used for running tests? (preprod, prod, another one?)

adamconnelly commented 1 year ago

@adamconnelly @truszkowski @marcinwyszynski

I'm troubleshooting: https://github.com/spacelift-io/terraform-provider-spacelift/actions/runs/6407726212/job/17395133360?pr=473

I noticed you've been recently active in this repo, do you know which instance is used for running tests? (preprod, prod, another one?)

@mwasilew2 I think the issue will just be that the new user management feature flags haven't been enabled for the test account (which is one of our preprod accounts). I'll message you on Slack with more info.

mwasilew2 commented 1 year ago

on preprod I got this:

Screenshot 2023-10-04 at 18 04 16

michieldewilde commented 1 year ago

I think we are missing a datasource for user groups? Or will that be in a separate PR?

marcinwyszynski commented 1 year ago

@michieldewilde I explicitly requested that the data sources are handled separately.

mwasilew2 commented 1 year ago

It's not pretty, but the user facing interface is consistent with the UI and docs.

spacelift-io / terraform-provider-spacelift