Tests need to be more flexible. We need to add more tests to cover VCS integration cases.
Let's use testConfig structure and fill them from env-vars.
In the future, we would consider changing to store secrets differently. We're using quite a lot of secrets; if we add all configuration key values there, we'll hit the limit.
For now, it's fine.
Also:
bugfix: We should look for default integration with an empty ID.
Type of change
[x] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (non-breaking change that adds documentation)
Related issues
Fix [#1]()
Checklists
Development
[x] Lint rules pass locally
[x] The code changed/added as part of this pull request has been covered with tests
[x] All tests related to the changed code pass in development
[ ] Examples for new resources and data sources have been added
[ ] Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
[ ] If the action fails that checks the documentation: Run go generate to make sure the docs are up to date
Code review
[x] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[x] Pull Request is no longer marked as "draft"
[x] Reviewers have been assigned
[ ] Changes have been reviewed by at least one other engineer
Description of the change
Tests need to be more flexible. We need to add more tests to cover VCS integration cases. Let's use
testConfigstructure and fill them from env-vars.In the future, we would consider changing to store secrets differently. We're using quite a lot of secrets; if we add all configuration key values there, we'll hit the limit. For now, it's fine.
Also:
Type of change
Related issues
Checklists
Development
false.)go generateto make sure the docs are up to dateCode review