spacelift-io / terraform-provider-spacelift

Terraform provider to interact with Spacelift
MIT License
74 stars 28 forks source link

feat: new resource `spacelift_gitlab_integration` #546

Closed tmeckel closed 4 months ago

tmeckel commented 4 months ago

Description of the change

This PR contains the new resource spacelift_gitlab_integration to create an GitLab integration for a Spacelift space.

[!IMPORTANT] The test TestGitLabIntegrationClearLabels currently fails, because it's impossible to clear assigned labels with a GraphQL mutation. Using nil or [] (empty array) makes no difference.

Type of change

Related issues

None

Checklists

Development

Code review

truszkowski commented 4 months ago

@tmeckel Thanks for the contribution❤️ We'll discuss it with the team and create a new PR with Your changes (secrets don't work with forks).

peterdeme commented 4 months ago

The test TestGitLabIntegrationClearLabels currently fails, because it's impossible to clear assigned labels with a GraphQL mutation. Using nil or [] (empty array) makes no difference.

@tmeckel this is a bug in our backend, I opened a PR for the fix. It should be deployed within 2-3 working days.

truszkowski commented 4 months ago

I've added cloned PR -> https://github.com/spacelift-io/terraform-provider-spacelift/pull/557 We'll merge it soon @tmeckel.

tmeckel commented 4 months ago

Closing because #557 has been merged.