Update provider.go to handle slash at api_key_endpoint

akmal-spacelift commented 1 month ago

Description of the change

Handles the slash at api_key_endpoint

Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (non-breaking change that adds documentation)

Related issues

internal ref: https://spacelift-io.slack.com/archives/C06L3C9L4P6/p1716303659139979?thread_ts=1716303553.805579&cid=C06L3C9L4P6 / https://spacelift-io.slack.com/archives/C03THR9LFH7/p1715837109837649?thread_ts=1715836160.097879&cid=C03THR9LFH7 / https://spacelift-io.slack.com/archives/C01724WEYJF/p1726588817203019

Checklists

Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development
[ ] Examples for new resources and data sources have been added
[ ] Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
[ ] If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] Pull Request is no longer marked as "draft"
[ ] Reviewers have been assigned
[ ] Changes have been reviewed by at least one other engineer

akmal-spacelift commented 1 month ago

updated https://github.com/spacelift-io/terraform-provider-spacelift/pull/568/files#diff-6e7375fac891c18ad89da0bd68e1e4993c044e8eaad6aa4926f1e3a14b4b0f1b

adamconnelly commented 1 month ago

Thanks @akmal-spacelift for fixing this! I've opened a new PR with your changes (the issue is that some of our PR checks don't run if you don't have write access to the repo) here: https://github.com/spacelift-io/terraform-provider-spacelift/pull/568.

I'm going to close this PR in favour of that one.

spacelift-io / terraform-provider-spacelift

Update provider.go to handle slash at api_key_endpoint #568