NickWaterton
commented
3 years ago This is my workaround for missing is_running in my createTimer class;
class createTimer(HABApp.Rule):
'''
General timer class
Restartable Timer, with cancel and reschedule functions
accepts float as seconds parameter (not claiming that the timer is that accurate though)
'''
def __init__(self, seconds=0, exec_func=None, *args, **kwargs):
super().__init__()
self.log = logging.getLogger('MyRule.'+self.__class__.__name__)
self.t = seconds
self.exec_func = exec_func
run = kwargs.pop('run', False)
self.args = args
self.kwargs = kwargs
if self.exec_func is None:
self.exec_func = self.dummy
self._task = self.run.at(self.get_milliseconds, self.exec_func, *args, **kwargs)
if not run:
self.cancel()
@property
def get_milliseconds(self):
return datetime.timedelta(milliseconds=int(self.t*1000))
@property
def is_running(self):
return bool(self._task.get_next_run() >= datetime.datetime.now())
#was
return not self._task.is_finished
@property
def time_till_run(self):
if self._task.get_next_run() > datetime.datetime.now():
return (self._task.get_next_run() - datetime.datetime.now()).total_seconds()
return 0
#was
if not self._task.is_finished:
return (self._task.get_next_run() - datetime.datetime.now()).total_seconds()
return 0
def dummy(self):
self.log.warning('This timer has no exec_func set')
def reschedule(self, seconds=None):
self.start(seconds)
def start(self, seconds=None, *args, **kwargs):
if seconds is not None:
self.t = seconds
if self.t >= 0:
self.cancel()
if not args:
args = self.args
if not kwargs:
kwargs = self.kwargs
self._task = self.run.at(self.get_milliseconds, self.exec_func, *args, **kwargs)
def cancel(self):
try:
self._task.cancel()
except Exception:
passI'm hoping this will work.
spacemanspiff2007
magnuslsjoberg
I just upgraded to 0.30.0
I followed the instructions: • Search for self.run_ and replace with self.run. • Search for self.run.in and replace with self.run.at • Search for .get_next_call() and replace with .get_next_run() (But make sure it's a scheduled job) • Search for HABAppError and replace with HABAppException
But I am running into many errors. The first issue is that HABApp now requires obsolete versions of packages, and if you do not have the exact version required, will not start. Had to downgrade many of my packages, just to get it to run.
eg. HABApp requires ujson==4.0.2, I had 4.0.3 - so won't start. same for aiohttp==3.7.4 (I had 3.7.5). Why not allow aiohttp>=3.7.4 ?
When I finally was able to start, there are many breaking changes not mentioned.
self.run.athas had the propertyis_finishedremoved, which breaks mycreateTimerclass, and causes most of my rules to fail.I am still trying to find a workaround for this. If a job is scheduled, how can I tell if it is pending, running, or has already run? I'm trying to use
.get_next_run()but I am not sure what this returns if the job has completed.When I cancel the task, if the task was previously cancelled, a new exception is raised
JobAlreadyCanceledException()which I now have to trap. I see no point in raising this exception.When I create a new
run.every(None,)task, I get an exceptionFirstRunInThePastError()which causes the entire rule not to load. What is the point of this exception? why not just run the task immediately? if the task is scheduled now (ie not in the past) this exception breaks the rule.This is the problem:
Also this fails when t==0:
This errors are caused by "/usr/local/lib/python3.8/dist-packages/eascheduler/jobs/job_base.py", line 96:
This is a bug, as
nowis not in the past. The line should be:But again, why? why not just run immediately?
Apparently
on_sunhas been silently dropped (not a big deal, I don't use it).I am still working through these errors, the biggest problem being
task.is_finishedbeing dropped. Any suggestions on how to re-create this vital property?