Allows input from external DMX sources.

spacemanspiff2007 / PyArtNet

"Python wrappers for the Art-Net protocol to send DMX over Ethernet"

GNU General Public License v3.0

67 stars 13 forks source link

Allows input from external DMX sources. #36

Open Breina opened 1 year ago

Breina commented 1 year ago

Provide a way to update a universe's data (partially).
Reverse output correct the DMX data, so that the same uncorrected input values reflect in the same corrected outputs.
Add a callback for channels that changed, containing the new values.

I had to make the output correction a class, so that I could give it 2 functions for applying corrections in two ways. Not sure if that's the pythonic way.

This is just a suggestion, let me know if you envision another approach.

Fixes #31

Breina commented 1 year ago

Your GitHub integration is pretty rad btw!

spacemanspiff2007 commented 1 year ago

I had to make the output correction a class, so that I could give it 2 functions for applying corrections in two ways. Not sure if that's the pythonic way.

I'm unsure about that. I think we should just accept the raw data as raw dmx input and not reverse correct it. I'll take a look at it in the next couple of weeks. Currently I think it's best to separate dmx input and output into different nodes. However I'll have yet to deep dive into your implementation to see what makes the most sense.

Breina commented 1 year ago

Alrighty take your time! Better to do it properly than to rush. :)