search

spacemanspiff2007 / PyArtNet

"Python wrappers for the Art-Net protocol to send DMX over Ethernet"
GNU General Public License v3.0
67 stars 13 forks source link

Add broadcast option #44

Closed hadleyrich closed 10 months ago

hadleyrich commented 10 months ago

Refs #9

It looks like the broadcast option added here:

https://github.com/spacemanspiff2007/PyArtNet/commit/6a4ef9d952aafe6a11f8f8dc63d8d782ed4a8d33

Has been lost along the way either due to refactor or on purpose. I needed this for something I was working on so thought I would contribute it back. If it's not wanted or if there's some other thing that I'm missing feel free to close out.

Thanks for the library :)

spacemanspiff2007 commented 10 months ago

Thanks for the PR. Broadcast support was removed because of artnet v4 spec:

grafik

So I don't think it's a good idea to merge it again.

hadleyrich commented 10 months ago

So I don't think it's a good idea to merge it again.

Makes sense, thanks for letting me know :)

Breina commented 10 months ago

If it helps, you are free to use multicast instead (still off-spec).

hadleyrich commented 10 months ago

Thanks to you both. I hadn't actually realised that I could use a directed broadcast to get around the socket permission issue so all good :)