search

spacemanspiff2007 / SmlLib

A library for the SML (Smart Message Language) protocol
GNU General Public License v3.0
27 stars 9 forks source link

add py.typed to package #14

Closed BubuOT closed 8 months ago

BubuOT commented 1 year ago

The py.typed file isn't automatically added to the wheel that's build during packaging/installation so it's never present in users python distributions. Add it via setuptools package_data facility.

spacemanspiff2007 commented 1 year ago

Imho it should be there. Maybe I have the path wrong ... . I'll take a look https://github.com/spacemanspiff2007/SmlLib/blob/863ec15b25a8316c599153553d6690b80b42adfb/MANIFEST.in#L2

BubuOT commented 1 year ago

I think the MANIFEST.in only controls the src package but the package_data field controls the build of the wheel package. See also here: https://github.com/hhk7734/python3-gpiod/pull/24

BubuOT commented 8 months ago

Thanks for integrating this. Unfortunately this didn't make it into the 1.3 release it seems, so typing is still not available for consumers of smllib? Or did I miss something somewhere?

spacemanspiff2007 commented 8 months ago

Yes - I saw it too late. The next release will incorporate this, but I'm hesitating to make an extra release just to integrate typing. Do you think it's worth it?

BubuOT commented 8 months ago

Do you think it's worth it?

I have a workaround in place for this (installing the package from git with pip) but I wouldn't mind being able to remove that with SMLlib 1.3.1. And other users might appreciate typing information being available out of the box.

But up to you of course, for me personally it's just nice-to-have, not blocking anything.