spacemeowx2 / ldn_mitm

Play local wireless supported games online
GNU General Public License v2.0
692 stars 98 forks source link

Firmware 14.1.0 + Atmosphere 1.3.1 - ldn_mitm panic on boot #119

Closed lowburger closed 2 years ago

lowburger commented 2 years ago

I confirm that ldn_mitm broken in Firmware 14.0.0 + Atmosphere 1.3.0 "Panic occurred while running Atmosphere" on boot.

SteveCookTU commented 2 years ago

For the automatic builds to update, devkitpro needs to be updated on the docker image to latest on the git (or the main package when they release a full update) along with Atmosphere libs

lowburger commented 2 years ago

Automatic I think it's not enough... SciresM write on his release note:

"a number of fairly major revisions were made to stratosphere (particularly surrounding filesystem code). Please Note: A number of changes made for this (and ones necessary in the process of adding support for 14.0.0) are api-breaking.If you're a developer and any of this caused your code to break, please feel free to contact SciresM#0524 for help updating your program."

dogty commented 2 years ago

I've made a fork and there were indeed changes to be made.

SteveCookTU commented 2 years ago

I don't have an environment setup locally to test the build of ldn itself, but the automatic build fails because libnx has not been officially updated for 14.0.0. I'm unsure what code actually within ldn may need to be changed.

dogty commented 2 years ago

I used the PR (https://github.com/switchbrew/libnx/pull/587). made a local libnx and made a fork https://github.com/dogty/ldn_mitm with the changes I've made. I've released a version as well

lowburger commented 2 years ago

I used the PR (switchbrew/libnx#587). made a local libnx and made a fork https://github.com/dogty/ldn_mitm with the changes I've made. I've released a version as well

Great! If you test and work on 14.0.0 then maybe do pull request for here?

dogty commented 2 years ago

I used the PR (switchbrew/libnx#587). made a local libnx and made a fork https://github.com/dogty/ldn_mitm with the changes I've made. I've released a version as well

Great! If you test and work on 14.0.0 then maybe do pull request for here?

I've tested it and it seemed to work with the firmware 14.0.0. I will wait for libnx to approve the PR that I based my build on before making a PR here.

lowburger commented 2 years ago

Again broken but I thinking dogty your next auto build will fix.

dogty commented 2 years ago

I ran an auto build https://github.com/dogty/ldn_mitm/actions/runs/2094417337 it seems to build but I haven't tried if everything works (don't see a reason it wouldn't). I'll test it later today. Thank you for noticing me.

Edit: use this nightly build instead https://github.com/dogty/ldn_mitm/actions/runs/2093295957

paristokyo36 commented 2 years ago

I ran an auto build ~https://github.com/dogty/ldn_mitm/actions/runs/2094417337~ it seems to build but I haven't tried if everything works (don't see a reason it wouldn't). I'll test it later today. Thank you for noticing me.

Edit: use this nightly build instead https://github.com/dogty/ldn_mitm/actions/runs/2093295957

pretty new here so forgive me if this is out of place but how do i get the nightly build i go to the page and i get a 404 error. Any help would be greatly appreciated !!

Kitocco commented 2 years ago

Automatic I think it's not enough... SciresM write on his release note:

"a number of fairly major revisions were made to stratosphere (particularly surrounding filesystem code). Please Note: A number of changes made for this (and ones necessary in the process of adding support for 14.0.0) are api-breaking.If you're a developer and any of this caused your code to break, please feel free to contact SciresM#0524 for help updating your program."

This is my first time trying to contribute to something like this, so I apologize for this being redundant in advance: Would the incompatibility of Automatic updates explain the syntax(?)/term errors in lines #170 and #177 of the latest build logs? There's a lot of asking about "did you mean... ?" for many terms that usually strat in pm. Also applies for line #201, #214, #221, #245, #263, #273, and #280. Hopefully this helps. Thank you for this very handy piece of homebrew software, by the way. :)

dogty commented 2 years ago

This is my first time trying to contribute to something like this, so I apologize for this being redundant in advance: Would the incompatibility of Automatic updates explain the syntax(?)/term errors in lines #170 and #177 of the latest build logs? There's a lot of asking about "did you mean... ?" for many terms that usually strat in pm. Also applies for line #201, #214, #221, #245, #263, #273, and #280. Hopefully this helps. Thank you for this very handy piece of homebrew software, by the way. :)

Yes this is exactly the reason. The libnx master branch doesn't have the PR SciresM created. You can use his PR and build the project yourself but you will still need to make some modifications in the code (the makefile needs to be modified) I've made the modifications needed to build the project with the new lib in my fork if you want to see what changed.

dogty commented 2 years ago

I have made a pull request https://github.com/spacemeowx2/ldn_mitm/pull/121

spacemeowx2 commented 2 years ago

I've merged the PR from @dogty , and I need some feedback to give me confidence to release the new version, please try this: https://github.com/spacemeowx2/ldn_mitm/actions/runs/2160625420

dogty commented 2 years ago

I'm going to delete my fork so more people can test this instead of using my build. As I mentioned earlier some people told me that they had trouble playing with people with the version 14.1.0, I personally didn't have an issue but I think it is worth investigating. Thank you again

lowburger commented 2 years ago

For me works, hope other can test.

noxskc commented 2 years ago

I've been using the unofficial Dogty idn mitm with a friend for 1 week on FW14.1.0 and it works great with no issues on several games This evening we played about 2 hours non stop still without problem