search

spacemeowx2 / ldn_mitm

Play local wireless supported games online
GNU General Public License v2.0
714 stars 104 forks source link

Mimic ldn threads, improve file logging and fix MTU issues #129

Closed TSRBerry closed 1 year ago

TSRBerry commented 1 year ago

I was debugging some issues with this module when I noticed that file logging doesn't work anymore. Which is why I added all the threads ldn itself would open and modified the logging functions.

I also replaced most of the ipinfo functions with libnx calls, since they are all supported now.

Additionally @AcK77 figured out that ldn sets the MTU to 1500 for it's own connection! So now the MTU is modified to 1500 in LanDiscovery.Initialize() and restored in LanDiscovery.Finalize() again.

The call within ldn itself seems to take place in CreateNetwork() and in Connect().

Thanks to @AcK77 for helping me work on this issue!

spacemeowx2 commented 1 year ago

LGTM, thank you for your awesome work!

TSRBerry commented 1 year ago

Just saw the build action fail. Make sure you are using the latest libnx release. You might also want to switch to devkitpro/devkita64 docker image