spacemeshos / go-spacemesh

Go Implementation of the Spacemesh protocol full node. 💾⏰💪
https://spacemesh.io
MIT License
761 stars 212 forks source link

fetcher: ignore fetch requests for empty hash or goldenAtx #4629

Open fasmat opened 1 year ago

fasmat commented 1 year ago

Description

At the moment the Handler in the activation package has to check if the ATX it is trying to fetch is types.EmptyATX or the golden ATX before calling GetAtxIds on the fetcher. Instead the fetcher itself should not try to fetch ATXs with those IDs but instead immediately return if instructed to fetch one of those two ATXs.

Affected code

This issue appears in commit hash: 265fb39

fasmat commented 1 year ago

cc @countvonzero