Open ivan4th opened 2 months ago
The identities.IterateMalicious doesn't check for married ATXs and thus yields the different set of malicious identities that you would get from going over every identity and calling identity.IsMalicious() for it, checking for true. identities.IterateMalicious is used during warmup. Related code: https://github.com/spacemeshos/go-spacemesh/blob/50910287e7f7122a841451a110a70c3f18e1f1bc/sql/identities/identities.go#L84-L85
identities.IterateMalicious
identity.IsMalicious()
true
identities.IsMalicious should handle equivocation sets correctly.
identities.IsMalicious
Description
The
identities.IterateMaliciousdoesn't check for married ATXs and thus yields the different set of malicious identities that you would get from going over every identity and callingidentity.IsMalicious()for it, checking fortrue.identities.IterateMaliciousis used during warmup. Related code: https://github.com/spacemeshos/go-spacemesh/blob/50910287e7f7122a841451a110a70c3f18e1f1bc/sql/identities/identities.go#L84-L85Expected Behavior
identities.IsMaliciousshould handle equivocation sets correctly.