Closed fasmat closed 1 week ago
bors try
Attention: Patch coverage is 92.15686%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 79.8%. Comparing base (
12a1e00
) to head (662e9ec
). Report is 5 commits behind head on develop.
Files with missing lines | Patch % | Lines |
---|---|---|
activation/handler_v2.go | 94.5% | 2 Missing and 2 partials :warning: |
activation/validation.go | 20.0% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
bors merge
Motivation
Closes #6433. Instead of proofing that the Commitment ATX in the
InvalidPost
malfeasance proof, include a valid label that indirectly proofs the correctness of the Commitment ATX.Description
This allows the same proof to be used for ATXv2 invalid posts independent of if the initial ATX is v1 or v2.
To make this change work after identifying an invalid post index the node has to verify the full PoST to see if any other index is valid. If not the ATX is considered syntactically invalid and no malfeasance proof is generated (and the ATX isn't stored in the DB). If at least one valid index is found this index is used in the malfeasance proof generation and the malfeasance proof is published.
Test Plan
existing tests were updated to fit the new behavior
TODO