[Merged by Bors] - Add nodepool lifecycle for systemtests

spacemeshos / go-spacemesh

Go Implementation of the Spacemesh protocol full node. 💾⏰💪

https://spacemesh.io

MIT License

760 stars 211 forks source link

[Merged by Bors] - Add nodepool lifecycle for systemtests #6464

Closed andres-spacemesh closed 5 days ago

andres-spacemesh commented 6 days ago

Motivation

This PR automates the creation and cleanup of GKE node pools specifically for system tests in the CI pipeline. The goal is to provide dynamic, on-demand node pools that can be created before system tests and cleaned up afterward, improving resource utilization and reducing costs.

Description

Node Pool Creation: A new step has been added to the GitHub Actions pipeline to create a preemptible GKE node pool with a custom name based on the pipeline run ID.
Node pool labels are added to track the pipeline ID for easier identification.
Node Pool Deletion: A subsequent cleanup step has been added to delete the node pool after system tests are completed, ensuring that no unnecessary resources are left running.

This helps maintain stability in the infrastructure during system tests.

fasmat commented 6 days ago

bors try

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.9%. Comparing base (f4de865) to head (d35474a). Report is 1 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #6464 +/- ## ======================================= Coverage 79.9% 79.9% ======================================= Files 353 353 Lines 46424 46424 ======================================= + Hits 37122 37123 +1 Misses 7197 7197 + Partials 2105 2104 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

dsmello commented 6 days ago

bors try

spacemesh-bors[bot] commented 6 days ago

try

Already running a review

fasmat commented 6 days ago

bors cancel

fasmat commented 6 days ago

bors try

spacemesh-bors[bot] commented 6 days ago

try

Already running a review

andres-spacemesh commented 6 days ago

bors cancel

andres-spacemesh commented 6 days ago

bors try

spacemesh-bors[bot] commented 6 days ago

try

Already running a review

andres-spacemesh commented 6 days ago

bors cancel

spacemesh-bors[bot] commented 6 days ago

try

Timed out.

andres-spacemesh commented 6 days ago

Wroked as expected: https://github.com/spacemeshos/go-spacemesh/actions/runs/11902954963

fasmat commented 5 days ago

bors merge

spacemesh-bors[bot] commented 5 days ago

Pull request successfully merged into develop.

Build succeeded: