Closed ivan4th closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.9%. Comparing base (
86ac1f4
) to head (4211315
). Report is 1 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
bors merge
Motivation
It is not correct to use
bufio.Buffer
to read the initial request and then passing the underlying stream to theStreamRequest
callback, asbufio.Buffer
may happen to read more data than necessary, making it unavailable for theStreamRequest
callback. This behavior has been obvserved when using QUIC, which tends to coalesce multiple writes more often.Description
This removes unneeded
bufio.Buffer
usage, which should not impact performance as the buffer was not being used for the actual request handling, anyway.Test Plan
Verified that this fixes QUIC write coalescing issue.