Change API - Githubissues

spacemeshos / gpu-post

Spacemesh proof of space time gpu optimized setup

GNU General Public License v3.0

29 stars 9 forks source link

Change API #6

Closed AndrewAR2 closed 4 years ago

AndrewAR2 commented 4 years ago

Update smesher gpu-post init #91

Replace the api-based gpu api with actual enum of available gpus and api availability. No way to make this backward compatible. Needed to support more desirable and intuitive behavior and reflect upcoming changes in the gpu post lib api.

avive commented 4 years ago

Very cool. Backwards compatibility is not a concern. Built and ran the test on os x - works as expected.

avive commented 4 years ago

Verified on Win 10 with an AMD Radeon RX 580 - works as expected with Vulkan.

moshababo commented 4 years ago

Thanks, looks good.

Few remarks:

performance field in PostComputeProvider struct can be removed, since it supposed to be implemented by a higher-level API.
Most of the options flags definition can be removed, since they were used to select gpu type, now replaced by provider_id.

avive commented 4 years ago

Built and tested on win 10 with an nvidia card (geforce RTX 2070). As expected, both nvidia cuda and nvidia vulkan were executed by the test app.