spacemeshos / pm

Project management. Meta-tasks related to research, dev, and specs for the Spacemesh protocol and infrastructure.
http://spacemesh.io/
Creative Commons Zero v1.0 Universal
2 stars 0 forks source link

node-config - implement validation of smeshing-proving-opts #254

Open monikasmolarek opened 1 year ago

monikasmolarek commented 1 year ago

Currently, we can put in the node-config.json (and custom config) any values that are just syntactically correct.

For example:

        "smeshing-proving-opts": {
            "smeshing-opts-proving-nonces": -1,
            "smeshing-opts-proving-threads": 999999
        },

postcli, go-spacemesh and smapp to be aligned

@pigmej feel free to add any details you think are important here, it's just a first draft not to forget about this aspect.

pigmej commented 1 year ago

@monikasmolarek we have a go-spacemesh issue for that validation but yeah good idea to start it also here.

https://github.com/spacemeshos/go-spacemesh/issues/3515#issuecomment-1649946952

Imho we should make a distinction between network and user facing params.