search

spacemeshos / post

Spacemesh POST protocol implementation
MIT License
19 stars 20 forks source link

[postcli] verify initialized POS data #184

Closed poszu closed 1 year ago

poszu commented 1 year ago

Closes #180

pigmej commented 1 year ago

@poszu we would need to also update readme to include that.

poszu commented 1 year ago

@pigmej

@poszu we would need to also update readme to include that.

Yes, thanks for reminding me. Please use "request changes" in PR Files changed tab 😉 . I added you to the reviewers to review the readme part when it's done. I'd really appreciate your input there.

Stizerg commented 1 year ago

If it shows 'post is invalid' could it indicate in what file the error occurred. If it's just one file we could simply regenerate a faulty file.

poszu commented 1 year ago

If it shows 'post is invalid' could it indicate in what file the error occurred. If it's just one file we could simply regenerate a faulty file.

It already prints that:

2023-07-21T11:21:54.865+0200    INFO    POS data is invalid: invalid label in file 108 at offset 928
poszu commented 1 year ago

We really need to have any docs before we can consider deeper testing of it. what does the -fraction=1 mean? whole post? 1% of post?

Do I need to specify id and / or commitmentATX or it will read it from postdata_metadata?

@pigmej, updated the readme. Please check

haverlinkfor commented 1 year ago

POS data is invalid: invalid label in file 108 at offset 928 after reinit of 108 file we again start from the first file. So we need to have an opportunity to start from 108