search

spacemeshos / post

Spacemesh POST protocol implementation
MIT License
20 stars 21 forks source link

fixed global nonce minimum #214

Closed pigmej closed 1 year ago

fasmat commented 1 year ago

The README as it is is correct. NonceValue in the second file (0000488e171389cce69344d68b66f6b4) is lower than the one in the first file (0000ffda94993723a980bf557509773e). Therefore the Nonce in the second file (98765) is the correct one to select 🙂.

pigmej commented 1 year ago

Then we have to make it more obvious:) but yeah I see now the logic there. Let me update :)

poszu commented 1 year ago

@nj what about this PR?

nj commented 1 year ago

Hi @poszu

I assume you have tagged the wrong one - don't know of this project :wink:

poszu commented 1 year ago

Hi @poszu

I assume you have tagged the wrong one - don't know of this project 😉

Sorry, I meant @pigmej who also uses "nj" in different places 😅.

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@b9039a3). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             develop    #214   +/-   ##
=========================================
  Coverage           ?   68.6%           
=========================================
  Files              ?      28           
  Lines              ?    1862           
  Branches           ?       0           
=========================================
  Hits               ?    1279           
  Misses             ?     435           
  Partials           ?     148

:loudspeaker: Have feedback on the report? Share it here.