search

spacemeshos / post

Spacemesh POST protocol implementation
MIT License
19 stars 20 forks source link

Change logging level of message to avoid confusion. #215

Closed fasmat closed 1 year ago

fasmat commented 1 year ago

A simple temporary workaround for the issue https://github.com/spacemeshos/go-spacemesh/issues/4789

This changes the level of logging messages that report unrecognised files from WARN to DEBUG.

PoST ignores files it doesn't know. At the moment the node creates additional files in the data directory. PoST reporting them as warning to users might mislead them into believing these files don't belong there or shall be deleted. Only showing these messages when debug logging is active should prevent this.

poszu commented 1 year ago

I'd not call it a fix but a workaround for a problem that has its source in go-spacemesh. These files should not be there, hence a warning. Could you add a TODO to bring back the warning level after go-sm is refactored to not store files in the same dir as POS?

fasmat commented 1 year ago

I added a TODO and updated the PR description to workaround instead of fix 🙂