search

spacemeshos / post

Spacemesh POST protocol implementation
MIT License
20 stars 21 forks source link

Fix scrypt close #277

Closed poszu closed 8 months ago

poszu commented 8 months ago

Fix segfaults when closing a postrs.Scrypt instance that first failed creation. Additionally, fix a deadlock in UT on platforms with more than 1 GPU.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.3%. Comparing base (ceaba06) to head (43e69c2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #277 +/- ## ======================================= Coverage 74.3% 74.3% ======================================= Files 29 29 Lines 1543 1545 +2 ======================================= + Hits 1147 1149 +2 Misses 258 258 Partials 138 138 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fasmat commented 8 months ago

Does this fix https://github.com/spacemeshos/post/issues/274 ?

poszu commented 8 months ago

Does this fix #274 ?

No, this fixes the crash on the Go side during Close() that happened when creating the initializer failed.