search

spacemeshos / smapp-lite

The light wallet application for Spacemesh network
2 stars 1 forks source link

Use hash router instead of normal URLs #58

Closed brusherru closed 1 month ago

brusherru commented 1 month ago

It fixes #47

github-actions[bot] commented 1 month ago

You can preview the changes at : https://9a5bcbac.smapp-lite-prod.pages.dev

dioexul commented 1 month ago

Validated. No more 404 (checked different pages)

brusherru commented 1 month ago

@monikasmolarek yeah, page refresh cleans up everything. And this behaviour was the same previously (if you run it on localhost, where it serves SPA correctly). So it's not a regression :)

Also, if we want to have a persistent state between "refreshes" then we will have the non-secret data (which we may want to keep private) decrypted in the local storage. So basically it will be the same as not asking password to unlock the wallet.

Anyway, if we want to have something like this, we need to define how and then implement it separately.

pigmej commented 1 month ago

Imo the current behavior is correct. As Kirill stated, making persistence between steps would mean that we keep the state somewhere, and that state would need to contain super critical data.

On Sun, Aug 4, 2024, 03:33 Kirill Shumilov @.***> wrote:

Merged #58 https://github.com/spacemeshos/smapp-lite/pull/58 into main.

— Reply to this email directly, view it on GitHub https://github.com/spacemeshos/smapp-lite/pull/58#event-13752691782, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADZI4QELEQDYCSP6TOQ7VDZPWAGNAVCNFSM6AAAAABL3JKQOKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTG42TENRZGE3TQMQ . You are receiving this because your review was requested.Message ID: @.***>