spacemeshos / smapp-lite

The light wallet application for Spacemesh network
2 stars 1 forks source link

Fix: lock wallet on minimizing / unfocusing entire browser window #68

Closed brusherru closed 4 weeks ago

brusherru commented 1 month ago

It fixes #64

github-actions[bot] commented 1 month ago

You can preview the changes at : https://5e9a0e62.smapp-lite-prod.pages.dev

brusherru commented 1 month ago

@monikasmolarek hmm, but it works for me. 🤔

I've doubled checked all of these cases:

  1. switching tab
  2. minimizing browser
  3. switching to another screen and another app

Both in Chrome and Safari...

Did you waited enough? It requires 2 minute to start the 30 seconds countdown. So you need to wait for 2.5+ minutes to lock the wallet.

The only case when it does not lock for me if I lock the macbook. For this case I can check if it were focused after some time — then lock immediately 🤔

monikasmolarek commented 1 month ago

Just not to leave this thread "ignored", I replied to Kirill on Slack while GH was down, showed recordings and it seems this issue should be investigated further/fixed differently.

github-actions[bot] commented 1 month ago

You can preview the changes at : https://b79f8466.smapp-lite-prod.pages.dev

dioexul commented 1 month ago

Checked. The 30s counted turned on right after 2 minutes in both cases - when the window is "active" and when the window is "not active" (I do smth in another app, the window is observed in the background). Note: incognito tab was used. MacOS, Chrome.

github-actions[bot] commented 1 month ago

You can preview the changes at : https://72e077b3.smapp-lite-prod.pages.dev

brusherru commented 1 month ago

Added a tiny fix that fixes #51 :)

pigmej commented 1 month ago

It works for me, tested with firefox and opera on macos.