Closed brusherru closed 3 days ago
You can preview the changes at : https://ca5d83e0.smapp-lite-prod.pages.dev
You can preview the changes at : https://765f10ab.smapp-lite-prod.pages.dev
@monikasmolarek thanks a lot! I have:
Also I can confirm that there is a bug as you recorded on the video above. I checked that we have the same bug in the main branch. So I will fix it within a separate PR. Created an issue for it: https://github.com/spacemeshos/smapp-lite/issues/79
Also, the current possibilities open a new use case.
For example: What if someone deletes both - all accounts, all keys -> The wallet is empty, we can of course create a new account - derive it from a foreign key, but the modal still has the "local key" drop-down, which is now empty. Should we allow to put there a hex and inform that it imports this key automatically while creating the account? Or should we hide the local key option? WDYT? Worth creating a feature request?
The transactions' modals/management handle view-only perfectly well, not mentioning the local key to sign when the key isn't there. 👌 So I thought managing accounts could also be more robust.
Should we allow to put there a hex and inform that it imports this key automatically while creating the account? Or should we hide the local key option?
It allows to put there a public key, but you need to switch to the foreign key, yeah. However, this won't be an issue when https://github.com/spacemeshos/smapp-lite/issues/82 will be implemented: Local Key dropdown will always have "Create a new key" option. So I think we don't need a separate issue for it.
You can preview the changes at : https://7eb429d1.smapp-lite-prod.pages.dev
Do we need "templateAddress" field here?
Also for me it is strange that I can replace the key for an existing account.
You can preview the changes at : https://fbeb1312.smapp-lite-prod.pages.dev
@dioexul I've added a yellow text under the name input saying that changing anything below will affect the account's address and change it only on your own risk. I think now it will be more clear that in a common case you should not change anything. But if you really have a mistake there — it will be possible to change anything.
Sounds good?
@brusherru yes, having a warning is better. I'm still thinking do we really need this functionality for all users, for developers - we definitely need it.
You can preview the changes at : https://19b5255a.smapp-lite-prod.pages.dev
It closes #42, closes #43, closes #44.
I had to refactor some input components (related to key and account selection). So please, check it out carefully, just in case I broke something and didn't find :) Actually more refactoring is needed, but I decided to finish it later.
Also, I moved adding of the new network inside the special "Edit networks" drawer (mb better to rename it into "Manage networks"?). Hopefully it's fine from the UX perspective.