spacemeshos / smapp-lite

The light wallet application for Spacemesh network
2 stars 1 forks source link

Add "Create new key" option to key selection drop down in Create/Edit Account popup #82

Open monikasmolarek opened 1 week ago

monikasmolarek commented 1 week ago

As in the rec. Creating a new account will create a new record on the list, but it will be the same exact account. It's only a displaying issue, the exported account files are also exactly the same.

https://github.com/user-attachments/assets/47f5e5f1-820d-4707-b255-d601e686aae3

Screenshot 2024-09-10 at 12 53 59

I noticed the same while testing the deleting keys/accounts. Delete Key- create a new key pair, you will get the exact same key over and over again. I thought that it could be the cache issue? To be checked, I could easily reproduce it

https://github.com/user-attachments/assets/17ef70f5-df44-4d3e-9876-9c1573a1fc01

brusherru commented 1 week ago

It's not a bug. You are using the same key, and that's why you get the same address.

However, we may need to tweak GUI and show a messages like:

brusherru commented 1 week ago

As we discussed on the call, I'll add "Create a new key" option to the dropdown and make it default (for SingleSig for sure). Also I think that showing a message is still actual. So I'll add it as well. Then I think it will be enough UX tweaks to not have confusion anymore. :)