Housekeeping - Githubissues

spacemeshos / smcli

Spacemesh command-line tool

https://spacemesh.io/

MIT License

8 stars 9 forks source link

Housekeeping #21

Closed fasmat closed 1 year ago

fasmat commented 1 year ago

This PR includes a few smaller cleanup tasks:

~Updates dependencies of smcli (replace spacemeshos/ed25519 with spacemeshos/ed25519-recovery)~ removed from PR
Introduces simple CI
Add dependabot
~Fix some linter errors~ removed from PR

lrettig commented 1 year ago

there will likely be a lot of conflicts with #20. I might pull some of these changes into there. maybe we could separately isolate and merge the CI + dependabot stuff. thanks.

fasmat commented 1 year ago

I removed the migration from spacemeshos/ed25519 to spacemeshos/ed25519-recovery to keep the scope of this PR small.

The migration is still necessary though. The new library is a copy of the standard library code (with one line changed to make key extraction possible) while the old one differs greatly from the crypto/ed25519 package and is also slower.

lrettig commented 1 year ago

I removed the migration from spacemeshos/ed25519 to spacemeshos/ed25519-recovery to keep the scope of this PR small.

The migration is still necessary though. The new library is a copy of the standard library code (with one line changed to make key extraction possible) while the old one differs greatly from the crypto/ed25519 package and is also slower.

thanks! i already did some migration in #20 (from our fork to the core code). will use spacemeshos/ed25519-recovery there as well!