search

spacemeshos / smcli

Spacemesh command-line tool
https://spacemesh.io/
MIT License
8 stars 9 forks source link

recovery import removed #36

Closed vavrajosef closed 1 year ago

vavrajosef commented 1 year ago

Closes #35

This removes recovery dependency mentioned in issue #35 . I am not sure whether the test in bip32_ed25519_wrapper_test.go makes sense anymore, because depndency "crypto/ed25519" does not provide api for public key extraction from signature. Only thing that is now tested is if message is signed. Maybe whole test file is no longer relevant.

lrettig commented 1 year ago

Thanks for the submission! I think TestNewMasterBIP32EDKeyPair would be more meaningful if it generated two keypairs using the same mnemonic, then ensured that it could sign using one keypair and verify using the other. It's not testing a lot but at least it would be testing that the process of generating keypairs is deterministic. Would you mind making this change?

vavrajosef commented 1 year ago

I just updated the test. Please let me know if this is what you had in mind.

lrettig commented 1 year ago

looks good, thanks!