Add more checks to CI - Githubissues

spacemeshos / smcli

Spacemesh command-line tool

https://spacemesh.io/

MIT License

8 stars 9 forks source link

Add more checks to CI #45

Closed fasmat closed 1 year ago

fasmat commented 1 year ago

Added various checks to the CI:

gofmt; fixed detected issues
golangci-lint + staticcheck; fixed detected issues

fasmat commented 1 year ago

Why is musl-gcc needed?

I'm not sure. @lrettig ?

lrettig commented 1 year ago

Why is musl-gcc needed?

We want to release a statically-linked build of smcli so that users don't need to worry about getting the dynamic libraries, putting them in the right place/setting env vars, etc. musl-gcc is designed for static linking. To be clear we also include dylibs in the upstream releases, use them for tests, etc.