spacemonkeygo / openssl

OpenSSL bindings for Go
http://godoc.org/github.com/spacemonkeygo/openssl
Apache License 2.0
473 stars 236 forks source link

Ed25519 key support #103

Closed parasssh closed 5 years ago

parasssh commented 5 years ago

Added basic support for Ed25519 cert/key. The PR supports Ed25519 key generation, sign and verify. Added unit tests. Fixes issue #102

parasssh commented 5 years ago

So, I would #ifdef based on the openssl version number in the shim.c. And if the version is >= 1.1.1, then define those field and functions otherwise they would be bad field or return failures. Is that what you had in mind? On related news, openssl just released the official 1.1.1 version today :)

zeebo commented 5 years ago

Yep! That's exactly right.

parasssh commented 5 years ago

Successfully tested the latest patch on the just released openssl-1.1.1 version.

zeebo commented 5 years ago

Seems good. The tests fail on 1.1.0, but I'll fix that up. Thanks!