search

spacemonkeygo / openssl

OpenSSL bindings for Go
http://godoc.org/github.com/spacemonkeygo/openssl
Apache License 2.0
474 stars 237 forks source link

low performance relatively to gotls #36

Closed kanekv closed 7 years ago

kanekv commented 9 years ago

I've tried running http servers: plain, openssl and gotls with this small program: https://play.golang.org/p/lY41nYV_uG.

Benchmarking it I've got following numbers: Plain HTTP: 72.5k rps gotls: 45k rps openssl: 24k

Is this expected or performance profile could be improved?

jtolio commented 8 years ago

The performance profile could probably be improved. I'll hopefully take a look soon (though, scale that out with the fact that I'm replying to this ticket 5 months later)

kanekv commented 8 years ago

we were able to achieve better performance bundling cgo calls

bak1an commented 8 years ago

Hi @Kane-Sendgrid

Could you share your findings and benchmarks?

Is this is the branch with the fix?

Thanks!

jtolio commented 8 years ago

oh there's a branch? if that's true can we make this a pull request and get it upstream?

bak1an commented 8 years ago

@jtolds perhaps we could do so.

I'm trying to figure out how significant the improvement is because for me numbers were almost the same.

bak1an commented 8 years ago

I've just checked this again using siege tool and it looks like @Kane-Sendgrid's master branch shows about the same performance as upstream.

Also, I was not able to get better performance with gotls, in all my tests openssl bindings were giving 4x more rps that gotls.

@Kane-Sendgrid could you share the details on your test setup?

Thanks

zeebo commented 7 years ago

Closing due to inactivity.