expand the brew tag to support full feature set on OSX

spacemonkeygo / openssl

OpenSSL bindings for Go

http://godoc.org/github.com/spacemonkeygo/openssl

Apache License 2.0

472 stars 237 forks source link

expand the brew tag to support full feature set on OSX #56

Closed ansel1 closed 7 years ago

ansel1 commented 8 years ago

There was a brew tag used in a few places which would re-enable building some features on OSX. I expanded the use of it so that it enables building all of the features and tests, including AES-GCM. Also sets some build flags to ensure the brew'ed version of openssl is found.

This also fixes building on el capitan. Prior to this pull request, the build would fail entirely because the openssl headers are no longer distributed with osx.

Also fixed a test to ensure if fails instead of hanging.

ansel1 commented 8 years ago

Fixes #48

But tests don't pass. The TestOpenSSLSimple and other tests which exercise SSL handshaking fail on OSX. Not sure why. SSH_get_error returns SSL_ERROR_SSL, but ERR_get_error returns 0. I don't see any other indication why the ssl handshake is failing.

zeebo commented 7 years ago

We will be requiring homebrew on os x from now on, so the brew tag is going away. I'll be including the documentation for this. Thanks.