spaceninjaserver / SpaceNinjaServer

A simple server for a small space ninja game
GNU General Public License v3.0
61 stars 36 forks source link

Endo drops received on mission do not save #356

Closed VampireKitten closed 1 month ago

VampireKitten commented 1 month ago

Any Endo obtained in a mission disappears from the mission results and is not added to the inventory. I will add pictures once I get Endo to drop again.

Sainan commented 1 month ago

Do you mean from like loot crates?

VampireKitten commented 1 month ago

Normal endo drops from enemies or crates. If you want a quick example to test on your end, any of the Arenas have tons of Endo drops, they shouldn't save after mission ends. This is an old issue that persisted since at least february.

Sainan commented 1 month ago

Could you try checking out https://github.com/spaceninjaserver/SpaceNinjaServer/pull/359 locally and seeing if it fixes the issue?

VampireKitten commented 1 month ago

Will do in the morning

VampireKitten commented 1 month ago

Quick test WITHOUT the new PR: Rathum, Arena, got an Endo drop:

image

Mission ends, no Endo on end screen result:

image

And no Endo on fusion menu:

image

VampireKitten commented 1 month ago

Test WITH new PR: Obtained Endo Drop in mission:

image

Does not show up in end results:

image

Does not appear in mod tab:

image

Sainan commented 1 month ago

I see, so the way this is handled is actually completely different from what they coded in here: image

Sainan commented 1 month ago

Should be fixed now by my PR for real.

VampireKitten commented 1 month ago

Will test as soon as I'm done with this Alert

VampireKitten commented 1 month ago

I can confirm it was, indeed, fixed now by your PR for real:

image