search

spaceninjaserver / SpaceNinjaServer

A simple server for a small space ninja game
GNU General Public License v3.0
67 stars 35 forks source link

Fixed typo in Baro's name in worldState.json #489

Closed Animan8000 closed 2 months ago

Sainan commented 2 months ago

Please submit this PR to the upstream project, instead.

Animan8000 commented 2 months ago

Please submit this PR to the upstream project, instead.

I'm not sure if I can follow correctly (sorry!) 😅 You mean like a different repository or so? If yes, which one (link)? Thx

0kolya0 commented 2 months ago

This PR no make sense as soon as Octavia takes the last worldState.php the error will be returned because the problem is in the original file.

Animan8000 commented 2 months ago

This PR no make sense as soon as Octavia takes the last worldState.php the error will be returned because the problem is in the original file.

I think I get what you mean. Because the original worldState file by DE has this typo as well, and any newer versions would re-introduce this silly typo? And there's no way to make a PR to fix the original file by DE (at least they don't provide an option, from what I remember)? Oh well, that's unfortunate then... sorry if I wasted anyone's time with this.

lonewolf0708 commented 2 months ago

Why not change the emu code to incorporate the typo "Baro'Ki Teel" ?

Sainan commented 2 months ago

I'm not sure what you mean, as there are no instances of "Baro Ki'Teer" in the codebase at present.

lonewolf0708 commented 2 months ago

What I'm trying to say is include the typo in the codebase rather than creating more work by trying to work around the typo.