Fix Inspect Code Warnings - Githubissues

spacepandas / cineaste-android

An Android Application to manage movies you would like to see and movies you have seen.

GNU General Public License v3.0

9 stars 2 forks source link

Fix Inspect Code Warnings #39

Closed fbernutz closed 5 years ago

fbernutz commented 5 years ago

Run ./gradlew lint to see all Android Lint Warnings.

This PR fixes most of them:

Remove redundant qualifier name
Make variable private
Replace negated isEmpty with isNotEmpty
Remove unneeded import
Reformat files
Delete unneeded namespace declaration in xml files
Add autofillHints for EditText
Fix warning for not handling all switch cases

It also updates kotlin version, gradle version and gradle dependencies.

Open warnings

There are still some open warnings. Maybe someone can help with them.

Correctness

[ ] 1 UnusedAttribute: Attribute unused on older versions (which should be suppressed)

Performance

[ ] 1 Overdraw: Overdraw: Painting regions more than once (which should be suppressed, because it is necessary)
[ ] 3 UnusedResources: Unused resources

Usability:Icons

[ ] 1 IconDipSize: Icon density-independent size validation