search

spacepxl / ComfyUI-Florence-2

Florence-2 image captioning and tasks
https://huggingface.co/microsoft/Florence-2-large
MIT License
59 stars 5 forks source link

matplotlib 3.9.0 bug workaround #11

Closed shole closed 2 months ago

shole commented 3 months ago

There is a bug in matplotlib 3.9.0 that will cause (rare) random failure when calling matplotlib.pyplot.subplots(), which will result in node crash. This issue does not appear in 3.8.x and is apparently due to be fixed in 3.9.1, which currently does not have a due date but github says is "94% complete".

https://github.com/matplotlib/matplotlib/pull/28269 https://github.com/matplotlib/matplotlib/issues/28267

I don't know if temporary environmental workarounds like this make sense to merge to main. This is likely not an issue in manual use but fatal in batch processing. For my purposes being able to disable previews would solve this, but I expect some people want to see those in batch processing as well.

shole commented 3 months ago

apparenlty this also fails perpetually if the windows computer is locked (desktop not programmatrically accessible) *facepalm recommend just downgrading to matplotlib==3.8.4 instead, which works fine

shole commented 2 months ago

for anyone impacted by this, 3.9.1 is out and works fine