SQLAlchemy quite some time ago (pre-0.6.0) renamed the postgres dialect to postgresql and recently (1.4) removed the compatibility for using the old name. CreateDBsabrs was using the old name, so the CI now fails. This is why #72 is failing. CreateDBsabrs was also using the reflect kwarg for the Metadata constructor, deprecated since 0.8.
This PR fixes the name and the constructor call and also adds a workflow running nightly to catch this kind of change in the future without waiting for a PR to be opened.
PR Checklist
[X] Pull request has descriptive title
[X] Pull request gives overview of changes
[X] New code has inline comments where necessary
[X] (N/A) Any new modules, functions or classes have docstrings consistent with dbprocessing style
[X] (N/A) Major new functionality has appropriate Sphinx documentation
[X] (N/A) Added an entry to release notes if fixing a major bug or providing a major new feature
[X] (N/A) New features and bug fixes should have unit tests
[X] Relevant issues are linked in the description (use Closes # if this PR closes the issue, or some other reference, such as See # if it is related in some other way)
SQLAlchemy quite some time ago (pre-0.6.0) renamed the
postgres
dialect topostgresql
and recently (1.4) removed the compatibility for using the old name.CreateDBsabrs
was using the old name, so the CI now fails. This is why #72 is failing.CreateDBsabrs
was also using thereflect
kwarg for theMetadata
constructor, deprecated since 0.8.This PR fixes the name and the constructor call and also adds a workflow running nightly to catch this kind of change in the future without waiting for a PR to be opened.
PR Checklist
Closes #
if this PR closes the issue, or some other reference, such asSee #
if it is related in some other way)