spacepy / dbprocessing

Automated processing controller for heliophysics data
5 stars 4 forks source link

deprecations: collections.abc, Engine.table_name #83

Closed dnadeau-lanl closed 2 years ago

dnadeau-lanl commented 3 years ago

Deprecation of collections.abc

/dbprocessing/DButils.py:704: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working
  or not isinstance(filename, collections.Iterable):

Deprecation of Engine.table_names() in sqlalchemy in unit tests

dbprocessing/unit_tests/test_tables.py:58: SADeprecationWarning: The Engine.table_names() method is deprecated and will be removed in a future release.  Please refer to Inspector.get_table_names(). (deprecated since: 1.4)
  sorted(tables), sorted(self.engine.table_names()))

Relation to an issue

60

Version of dbprocessing

https://github.com/spacepy/dbprocessing/commit/5c0082c9c64e0b7c0b244ee168f4e571a19109dd

Closure condition

We don't have deprecated warning

tirkarthi commented 3 years ago

I have created https://github.com/spacepy/dbprocessing/pull/84 for review