Closed tirkarthi closed 2 years ago
Thanks for taking a shot at this. Normally we try to preserve namespacing per PEP 20 (this isn't consistent throughout the codebase) and we definitely do need some tests to cover this. (I'll probably pull over the warnings testing infrastructure from SpacePy).
Fixed in #120
Superseded by #120 for the reasons described in that PR.
Fixes #83
PR Checklist
New code is easier to review, integrate and maintain if it's consistent with the style of the rest of the dbprocessing code. Please try to follow as much of this checklist as you can for your PR. If a given item is not relevant to your PR, please check it off, add "(N/A)" to the start of the line, and include a description below the checklist.
If you don't know how to complete something in the checklist, go ahead and submit the PR as a draft and ask for help.
Some additional suggestions are given below.
Please also see our Code of Conduct so that the dbprocessing community remains welcoming and inclusive.
Go ahead and replace the text above (and this line!) with your pull request description.
Closes #
if this PR closes the issue, or some other reference, such asSee #
if it is related in some other way)