Closed maximt closed 1 year ago
I'm a bit confused.
Trying to test locally, here are the results:
Newly added submitUpload
doesn't seem to be called in any of the cases, not sure if it's needed.
Could you please specify which cases this PR intends to fix?
Pasting image file:
- directly in the comment textarea: works, enter: works ✅
- in the upload form: inserts file name, enter/submit inserts an a filename instead of url ❌
https://github.com/spaceshelter/orbitar/pull/345#pullrequestreview-1618684952
It strange, it was expected that both cases should work.
Newly added
submitUpload
doesn't seem to be called in any of the cases, not sure if it's needed.
This is need to prevent the page reloading on submit, but seems it need to change button type=submit too.
Verified on windows - copied file in File Explorer using right button and ctrl+v into Chrome - pasted image content correctly
Verified on windows - copied file in File Explorer using right button and ctrl+v into Chrome - pasted image content correctly
Are you checking two cases:
Verified on windows - copied file in File Explorer using right button and ctrl+v into Chrome - pasted image content correctly
Are you checking two cases:
- Ctrl-V the file into the comment textarea (works for me)
- Ctrl-V the file into the upload form (when it's already open) — doesn't work for me
Yes, both cases are working as expected - pasting image content and previewing it
Found and fixed the problem. The Ctrl/Cmd-V behavior was different in the upload form, depending on whether the focus was on the input element.
Checklist (updating):
Supported image drag into the editor.
Supported image drag into the editor.
works for me.