spaceshelter / orbitar

Experimental collective social/blogging platform with self-regulation.
MIT License
62 stars 24 forks source link

RSA-encrypted direct messages, attempt 2 #367

Closed Aivean closed 11 months ago

Aivean commented 1 year ago

Now the public key is stored on the server, created in settings:

image image image

When user has public key set, "secret message" button is available in the comment editor:

image

This button opens modal which allows to write a text message:

image image image image image
pazoozoo42 commented 1 year ago

I'm super excited about this feature, thank you! I fetched the branch and was able to make it work but didn't yet get to the code review itself. But I already have a couple of comments about the flow and UI: 1) Need to make clear that password is separate from your account password and can be used to read private messages only (or call it PIN? or show INFO section right away). Initially I thought this is my main password input for inbox creation confirmation

2) need better explanation on how it works, it's not clear right away that you can send private messages to users who have created their private key and only as comments in their posts

3) need to show error on entering a wrong password, it's not clear what is going on when wrong password is entered

4) need to hide send icon for me in my own posts, this can lead to confusion

5) would be great to hide sender name of the private comment so that this could be used as a private inbox. Or having this as an option at least

Will be looking into code soon and will leave more feedback. Great improvement, thank you!

Aivean commented 1 year ago

Thanks for the review and suggestions!

  1. Need to make clear that password is separate from your account password and can be used to read private messages only (or call it PIN? or show INFO section right away). Initially I thought this is my main password input for inbox creation confirmation

Makes sense.

  1. need better explanation on how it works, it's not clear right away that you can send private messages to users who have created their private key and only as comments in their posts

Any ideas on how to achieve that? Need to brainstorm the better explanation. Also, not only in their posts, any direct reply should work.

  1. need to show error on entering a wrong password, it's not clear what is going on when wrong password is entered

👍

  1. need to hide send icon for me in my own posts, this can lead to confusion

👍

  1. would be great to hide sender name of the private comment so that this could be used as a private inbox. Or having this as an option at least

This is not trivial. I guess barmalini can be used as a workaround. Please check the discord design discussion for the full fledged inboxes.

pazoozoo42 commented 1 year ago

This is not trivial. I guess barmalini can be used as a workaround. Please check the discord design discussion for the full fledged inboxes.

Good point, I keep forgetting we have barmalini, this means there is already a way to send anonymously, nice

Any ideas on how to achieve that? Need to brainstorm the better explanation. Also, not only in their posts, any direct reply should work.

I think just simple and clear message would work. Once we decide on the message, we also could test how clear it is by asking users unaware of the feature to let us know if the message is clear enough. ChatGPT suggestions:

image
Aivean commented 1 year ago

@pazoozoo42, addressed most review comments.