search

spaceshelter / orbitar

Experimental collective social/blogging platform with self-regulation.
MIT License
62 stars 24 forks source link

Inline expand for internal links (posts and comments) #374

Closed Aivean closed 9 months ago

Aivean commented 9 months ago

Adds the ability to expand the content of internal links inline.

Demo:

https://github.com/spaceshelter/orbitar/assets/2865203/4bba1603-4636-405b-ae1a-150a986a3f04

Aivean commented 9 months ago

Approving but it stinks a bit - don't like how we are mixing react and DOM manipulations. Also it is obvious that we need an app level - will try adding that in upcoming weeks

Wdym by app level?

Aivean commented 9 months ago

Thanks for the review!

4vanger commented 9 months ago

Approving but it stinks a bit - don't like how we are mixing react and DOM manipulations. Also it is obvious that we need an app level - will try adding that in upcoming weeks

Wdym by app level?

Approving but it stinks a bit - don't like how we are mixing react and DOM manipulations. Also it is obvious that we need an app level - will try adding that in upcoming weeks

Wdym by app level?

Sorry, I meant app level store

Aivean commented 9 months ago

Wdym by app level?

Sorry, I meant app level store

We already have it: https://github.com/spaceshelter/orbitar/blob/3e815a8baa6f71dd44039c4096b28cea0a2068a5/frontend/src/AppState/AppState.tsx#L43

Aivean commented 9 months ago

@4vanger, can you stamp again please?