spaceshipyard / mars-rover-dispatcher

Apache License 2.0
1 stars 1 forks source link

Fix bug with camera control (losing control) #25

Closed vnabatov closed 6 years ago

vnabatov commented 6 years ago

currently robot could stuck with camera control command and pilot lose control steps:

  1. Send moving command
  2. Send Camera command
  3. Send stop command ER: robot stops AR: robot continue moving and doesn't react on any commands
vnabatov commented 6 years ago

repeated only with the joystick

probably fixed here https://github.com/spaceshipyard/mars-rover-dispatcher/commit/75949a1aad1f6b666cee3dc16c58bdb719e58c49 need to check on the real robot

vnabatov commented 6 years ago

the issue is still actual, probably related with poor internet connection

vnabatov commented 6 years ago

we need to force socket.io to use the WebSocket, current problem caused by using of longPolling

chaos-adept commented 6 years ago

for information, we have a sandbox for experiments which has certificates - https://github.com/Code-Rush-Experement/electronic-queue

chaos-adept commented 6 years ago

for information, i have tried the electronic-queue, and it works: image

I will try to test the same https approach in the dispatcher

chaos-adept commented 6 years ago

I have tried to run the dispatcher on the my laptop, and it works over websocket: image engine.io-client:socket socket receive: type "open", data "{"sid":"draL28yzhRwSg-tnAAAB","upgrades":["websocket"],"pingInterval":25000,"pingTimeout":60000}" +1ms

so far it looks that the bug is a problem of the environment rather than the code base.

vnabatov commented 6 years ago

on laptop with mock server runs with the web socket too, very confusing

chaos-adept commented 6 years ago

for your information, the status of messages was implemented in the https://github.com/spaceshipyard/mars-rover-dispatcher/issues/26

chaos-adept commented 6 years ago

on laptop with mock server runs with the web socket too, very confusing

i think that options are following:

chaos-adept commented 6 years ago

the workaround for proxy blocking is under progress in #31

vnabatov commented 6 years ago

fixed, tested